Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider generating all schemas as part of the same json-schema file #40

Open
bruno-f-cruz opened this issue Jun 19, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bruno-f-cruz
Copy link
Collaborator

bruno-f-cruz commented Jun 19, 2024

Pros:

  • Simplify serialization/deserialization
  • simplify bonsai classes and namespaces
  • Only requires one operator

Cons:

  • Refactor workflows due to namespace changes
  • No longer able to "mix and match" across tasks (which should be ok)
  • More potential for naming clashes?

Notes:

For simplicity, the user would still be allowed to generate the jsonfiles individually. The only difference is that we would deserialize at the level of the individual schemas instead of the container for all 3

@bruno-f-cruz bruno-f-cruz self-assigned this Jun 19, 2024
@bruno-f-cruz bruno-f-cruz added enhancement New feature or request help wanted Extra attention is needed labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant