Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index a full srcset for the post thumbnail #3693

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Oct 10, 2023

Description of the Change

This PR allows to index the post thumbnail srcset and sizes

Closes #3449

How to test the Change

  1. Index the post.
  2. Verify if thumbnail has srcset and sizes in Elasticsearch

Changelog Entry

Changed - Index srcset and sizes for post thumbnail

Credits

Props @burhandodhy @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Base automatically changed from 5.0.0 to develop November 1, 2023 14:16
@KalleVuorjoki
Copy link

This seems very useful feature, is there something missing here or is rebase all that is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index a full srcset for the post thumbnail
2 participants