Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: make boolean operations more robust by automatic retries and inp… #33

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

ENH: make boolean operations more robust by automatic retries and inp… #33

wants to merge 4 commits into from

Conversation

mauigna06
Copy link
Contributor

…ut meshes triangulation features

Fixes zippy84/vtkbool#81

@lassoan
Copy link
Contributor

lassoan commented Aug 10, 2024

Thank you very much! Could you please post a screenshot of the GUI?

@mauigna06
Copy link
Contributor Author

Hi, yes :)

Screenshot from 2024-08-10 14-00-01

@mauigna06
Copy link
Contributor Author

mauigna06 commented Aug 10, 2024 •
edited
Loading

I need to add another commit to fix a small problem :)

@mauigna06
Copy link
Contributor Author

If the boolean filter receives any empty input it makes Slicer crash when the filter updates. So I need to handle that beforehand:

----------------------------------------------------------------------------------------------------
inputAValid		|	inputBValid		|	operation	|	do what?
----------------------------------------------------------------------------------------------------
	0		|	0			|	union		|	append
	0		|	1			|	union		|	append
	1		|	0			|	union		|	append
	1		|	1			|	union		|	boolean operation
----------------------------------------------------------------------------------------------------
	0		|	0			|	intersect	|	append
	0		|	1			|	intersect	|	empty
	1		|	0			|	intersect	|	empty
	1		|	1			|	intersect	|	boolean operation
----------------------------------------------------------------------------------------------------
	0		|	0			|	diffA-B		|	append
	0		|	1			|	diffA-B		|	empty
	1		|	0			|	diffA-B		|	inputA
	1		|	1			|	diffA-B		|	boolean operation
----------------------------------------------------------------------------------------------------
	0		|	0			|	diffB-A		|	append
	0		|	1			|	diffB-A		|	inputB
	1		|	0			|	diffB-A		|	empty
	1		|	1			|	diffB-A		|	boolean operation
----------------------------------------------------------------------------------------------------

@mauigna06 mauigna06 mentioned this pull request Aug 12, 2024
Closed
lassoan
lassoan reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cleaned up and simplified the code a bit, but let's not merge it until it is confirmed that it is needed. If the fix described in zippy84/vtkbool#43 (comment) works then this pull request will probably not be needed.

@lassoan lassoan marked this pull request as draft August 26, 2024 19:36
@mauigna06
Copy link
Contributor Author

Thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous output handling
2 participants
@mauigna06 @lassoan