Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Support #432

Open
HamoBoker opened this issue Nov 5, 2024 · 4 comments
Open

RTL Support #432

HamoBoker opened this issue Nov 5, 2024 · 4 comments
Labels
bug Something isn't working needs repro Needs reproducible example

Comments

@HamoBoker
Copy link

Current behaviour

Hi

First of all thanks a lot for your great work i really appreciate it.

i have issue when switching the app to RTL and opening DatePickerModal the dates doesn't appear and stays empty, on LTR everything works properly.

Thank you in advance

Expected behaviour

Dates appear

How to reproduce?

// index.js
import {I18nManager} from 'react-native'
import {ar, registerTranslation} from 'react-native-paper-dates'

registerTranslation('ar', ar)
I18nManager.allowRTL(true)
I18nManager.forceRTL(true)

open date picker modal

Preview

drawing

Your Environment

software version
ios 18.1
android 13
react-native 0.75.4
react-native-paper 5.12.5
node 20
@HamoBoker HamoBoker added the bug Something isn't working label Nov 5, 2024
@iM-GeeKy iM-GeeKy added the needs repro Needs reproducible example label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Nov 5, 2024

PRs are welcome!

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

@github-actions github-actions bot added the stale label Dec 6, 2024
@OriGummy
Copy link

+1
have a look at #36 , @0had0 solved it there

@github-actions github-actions bot removed the stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs repro Needs reproducible example
Projects
None yet
Development

No branches or pull requests

3 participants