Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Webhook Improvements #92

Open
swissspidy opened this issue Nov 2, 2018 · 0 comments
Open

GitHub Webhook Improvements #92

swissspidy opened this issue Nov 2, 2018 · 0 comments
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Bug Bugs and regressions in existing functionality

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Nov 2, 2018 •
edited
Loading

Issue Overview

Two things I noticed:

  • GitHub sends the X-Hub-Signature header also for pings and we currently don't check for that.
  • The signature is optional and we currently don't support that.
@swissspidy swissspidy added [Type] Bug Bugs and regressions in existing functionality [Component] API Concerns REST API Endpoints, e.g. for incoming webhooks labels Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Bug Bugs and regressions in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swissspidy