Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Advanced Handling of When Tools are available #160

Open
njbrake opened this issue Nov 11, 2024 · 1 comment
Open

More Advanced Handling of When Tools are available #160

njbrake opened this issue Nov 11, 2024 · 1 comment

Comments

@njbrake
Copy link
Contributor

njbrake commented Nov 11, 2024

Hi! Maybe I am missing something but is there more of a description available about why this logic exists? This does not work with AWS Sagemaker either, since tools are not supported by Sagemaker so the get_litellm_params liteLLM function throws an Exception about unsupported parameters.

and ("ollama" in model or "azure/gpt-4o-mini" in model)

Maybe a short term hack is to add "sagemaker" to this if statement, but I'm not sure if other things would need to be adjusted as well?

@shreyashankar
Copy link
Collaborator

shreyashankar commented Nov 11, 2024

Thanks for making the issue! We've just been adding models ad-hoc, when users complain that tool use significantly degrades the output quality (or is entirely unsupported).

A hacky fix is to put sagemaker in that if statement (but you can only have single-key output schemas for operations unfortunately). Feel free to make a PR if adding a "sagemaker" check works :-)

Separately, we are exploring using outlines; as in #127

njbrake added a commit to njbrake/docetl that referenced this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants