Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement valuable-http, a bridge between the http crate and valuable #45

Open
carllerche opened this issue May 21, 2021 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@carllerche
Copy link
Member

carllerche commented May 21, 2021

Until Valuable reaches 1.0, http will most likely not depend on valuable, so we should provide a bridge. This crate would provide wrappers for types in http that implement Valuable.

Then, users can do:

use valuable::Valuable;
use valuable_http::Request;

Request::from(my_request).as_value()

One open question: what argument should the Request type take?

  • http::Request
  • &http::Request
  • impl AsRef<http::Request>
@carllerche carllerche added the help wanted Extra attention is needed label May 22, 2021
@aatifsyed
Copy link

I'll give this a go :) - a crate in this project or elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants