Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .PHONY line #24

Open
adius opened this issue Oct 5, 2017 · 3 comments
Open

Ignore .PHONY line #24

adius opened this issue Oct 5, 2017 · 3 comments
Labels

Comments

@adius
Copy link

adius commented Oct 5, 2017

Many style guides suggest putting the .PHONY before the target.
This is also my preferred style.

# Remove all build artifacts and dependencies
.PHONY: clean
clean:
	-rm -r build

This, however, leads to a not very helpful help output

$ make help

  .PHONY                        Remove all build artifacts and dependencies

I think mmake should ignore the .PHONY line.

@tj
Copy link
Owner

tj commented Oct 5, 2017

SGTM

tryzniak added a commit to tryzniak/mmake that referenced this issue Nov 23, 2017
@tj tj closed this as completed in #26 Nov 23, 2017
@adius
Copy link
Author

adius commented Jan 30, 2018

This was only fixed if .PHONY is before the comment, and not if it is after the comment like in my example 🙈.

I guess you should reopen it ...

@tj
Copy link
Owner

tj commented Jan 30, 2018

ahahah :D

@tj tj reopened this Jan 30, 2018
@zph zph added the bug label Sep 21, 2019
zph added a commit that referenced this issue Sep 21, 2019
Follow on from PR #24 to bring CI/tests into passing state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants