-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate no results from invalid/unsupported filters #31
Comments
Accepted. I couldn't believe no other providers can handle such queries! |
Do you know how exactly the spacegroups can be queried? |
Currently, however, the specification does not have means to query spacegroups. I can think of two methods to detect and report invalid/unsupported queries:
|
Alright. I better remove the example with the spacegroup then. I expected this is fully valid example. |
It is not valid, indeed. Moreover, according to the specification, |
Closed by the |
Re-opening wrt Materials-Consortia/OPTIMADE#405 |
When searching for
spacegroup="P1"
on https://optimade.science, all providers but MPDS result in "No results". However, filterspacegroup="P1"
is not defined in the OPTIMADE standard, thus it is nonstandard. Therefore, replies "No results" from other providers give false impressions that these databases do not contain P1 structures, which some of them do. Therefore I propose catching HTTP 4xx and 5xx from providers and reporting them as such.The text was updated successfully, but these errors were encountered: