Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Established connections exit when Mode=Both #19

Open
DemonZack opened this issue Aug 15, 2022 · 3 comments
Open

Established connections exit when Mode=Both #19

DemonZack opened this issue Aug 15, 2022 · 3 comments

Comments

@DemonZack
Copy link

When Mode=Both, connections that have already been established exit. Normally, Both Close and Stop() cannot exit properly

Close() notifies watchNotifyClose and reestablishes the connection. Stop() only exits Consumer, but Producter does not exit properly

Therefore, it is recommended to adjust at watchNotifyClose and then complete consumer and producer exit via Close() or Stop()

image

@dselans
Copy link
Contributor

dselans commented Aug 15, 2022

Great call! Will update and create a new release. Thank you!

@DemonZack
Copy link
Author

Not at all. It's my pleasure.

@dselans
Copy link
Contributor

dselans commented Dec 27, 2022

Wow, I think we totally missed this. We are currently testing out rabbit's official go lib and will update this afterwards.

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants