Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel name is case sensitive #494

Open
bmillham opened this issue Aug 16, 2024 · 11 comments · May be fixed by #668
Open

Channel name is case sensitive #494

bmillham opened this issue Aug 16, 2024 · 11 comments · May be fixed by #668
Assignees
Labels

Comments

@bmillham
Copy link

If you join a channel, say #Rockit and a message is send to #rockit halloy does not display the message.

The channel should not be case sensitive.

@casperstorm
Copy link
Member

@bmillham, could you show me how to reproduce this, and on which network?
I tried the following on Libera:

Test 1

  1. Halloy joins #FOObaz
  2. Second client joins #foobaz
  3. Second client sends "hi"
  4. Halloy sees "hi"

Test 2

  1. Second client joins #ROCKit
  2. Halloy joins #rockit
  3. Halloy sends "hi"
  4. Second client sees "hi"

@glguy
Copy link

glguy commented Aug 31, 2024

Libera (solanum) normalizes channel names. You can't reproduce the bug there.

@casperstorm
Copy link
Member

Libera (solanum) normalizes channel names. You can't reproduce the bug there.

That explains. Thank you.

@gAlleb
Copy link

gAlleb commented Oct 23, 2024

Hi @casperstorm
Tested on 2014.12 and on 825be98
I've encountered this bug too on russian ircnet.ru network.

If you connect to it via ircnet.ru:6688 server and join #usue channel - the channel you've joined will be #Usue and you will be able to see only messages from those who are connected to #Usue somehow but you'll see full users list.

If you connect to it via irc.386.ru:6688 server and join #usue channel - the channel you've joined will be #usue and you will be able to see only messages from those who are connected to #usue somehow but you'll see full users list.

With all other clients I've tried - there is no such behavior: every message from every user is seen on the channel. Must say it has confused me a lot from the start. But I do think it's connected with how Halloy treats case sensitivity. It joins the same channel butt somehow ignores some messages (the are not visible anywhere).

Been able to reproduce: while being connected through soju I've changed the network and ended up on 2 cchannels at the same time #usue and #Usue (which is the same channel actually).
If I write in #usue buffer - I don't see those messages in #Usue buffer. Same goes for some messages from some of the users on the channel.
Снимок экрана 2024-10-23 в 08 42 58

Here is screenshot from gamja (which like all other clients doesn't have this problem)
Снимок экрана 2024-10-23 в 08 53 22

Really like Halloy so I think something could be done. Because at the moment I'm unable to use it on some networks.

@casperstorm
Copy link
Member

Will start looking into this next @gAlleb!

@gAlleb
Copy link

gAlleb commented Oct 23, 2024

Thank you!

ircnet.ru doesn't use Solanum but historically uses PTlink (PTlink7.1.0-rc2). I'm not an expert but I assume that depending on the linked server inside this network it (the server) sends some kind of raw channel data that differs in cases (and those servers somehow store channel data with different cases due to unknown reasons - maybe from the point when a channel has been created on one server and then recreated with lower case on another). Maybe not.

Because when you are inside the network and you /join #usue (or /join #uSUe or /join #usUE ) - you end up either on #usue or #Usue depending on the server you are being connected to and (when using Halloy) will see only messages from the users that have the same channel name. But i'm glad that could catch this cause at the beginning I thought that I'm going mad when I've seen a person talking and talking to himself :)

@tarkah
Copy link
Member

tarkah commented Oct 23, 2024

We don't handle server casemapping settings which dictate how we should deal with case sensitivity / case conversion.

We need to handle this properly which will fix this issue

@gAlleb
Copy link

gAlleb commented Oct 23, 2024

We need to handle this properly which will fix this issue

True. Looking forward. Thank you!

Also if it's possible, it would be really nice if you could share some thoughts and insights on the cause of this bug after the fix. For educational purposes :) Cause it's an interesting issue.

@gAlleb
Copy link

gAlleb commented Oct 24, 2024

Same goes for user names sometimes:

Снимок экрана 2024-10-24 в 19 06 45

@voltagex
Copy link

I can reproduce this with soju - bouncerserv vs BouncerServ

image

@andymandias andymandias self-assigned this Nov 19, 2024
@vk3dan
Copy link

vk3dan commented Dec 5, 2024

This issue also affects users of the GeekShed network as their servers do not normalise capitalisation of channel names either.

vk3dan added a commit to vk3dan/halloy that referenced this issue Dec 6, 2024
This seems to fix the issue described in squidowl#494
@andymandias andymandias linked a pull request Dec 7, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants