Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to disable superfluous S3 checks #144

Open
zaza opened this issue Oct 19, 2023 · 3 comments
Open

Add a flag to disable superfluous S3 checks #144

zaza opened this issue Oct 19, 2023 · 3 comments

Comments

@zaza
Copy link

zaza commented Oct 19, 2023

In order to squeeze as much out of the connector as possible, we would like to have a way to disable certain superfluous (in our opinion) S3 checks like Utils.checkThatBucketHasObjectLifecycleConfiguration.

There's definitely value in having them on by default, but once addressed, it would be great to have an option to turn them off, so no extra calls are made except for the essentials.

@bsharifi
Copy link
Collaborator

@zaza
Thank you for the suggestion on ways to improve the connector. While I cannot promise any specific timeframes, we are considering this suggestion for future improvements to the connector. As always, please feel free to contribute your own code improvements as a PR and we will be happy to review and merge it.

@zaza
Copy link
Author

zaza commented Nov 23, 2023

Thanks @bsharifi ! I will definitely consider contributing a fix. I already created #148 which is related.

@zaza
Copy link
Author

zaza commented Dec 3, 2024

@bsharifi seems like 025d78a has addressed this, am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants