Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If layer URI's aren't usable by plugin, plugin has laggy errors #21

Open
HeatherHillers opened this issue Mar 14, 2022 · 1 comment
Open

Comments

@HeatherHillers
Copy link

In my project, the plugin is unable to create a connection based on the URI's of the layers in the legend. (I don't know why yet, when I do I will make a ticket.)

When the Plugin can't create the connection, it can be very bad for the user, because every click on a legend layer results in a plugin error. Since the plugin error involves trying and failing to run a query, it is also a laggy error. The behavior could be more safe in this state.

I made a pull request with a suggested fix.

@hdus
Copy link
Member

hdus commented Mar 14, 2022

@HeatherHillers thanks a lot for your contribution! I have created the new on-off_icon branch for testing and discussing this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants