New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHubPaginator for all list GitHub api calls #109

Open

soullivaneuh opened this issue May 28, 2016 · 0 comments

Member

soullivaneuh commented May 28, 2016

For example, this is wrong:

dev-kit/src/Console/Command/MergeConflictsCommand.php

Line 59 in 8956619

    
           foreach ($this->githubClient->pullRequests()->all(static::GITHUB_GROUP, $repositoryName) as $pullRequest) {

Because if a project has many opened PR, we will have only the page 1, not all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment