Skip to content

Commit

Permalink
3.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
soullivaneuh committed Mar 8, 2017
1 parent f7eabe5 commit 17162cc
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 6 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [3.5.0](https://github.com/sonata-project/SonataMediaBundle/compare/3.4.0...3.5.0) - 2017-03-08
### Changed
- `MediaController::downloadAction` signature to include Request as first parameter

This comment has been minimized.

Copy link
@jordisala1991

jordisala1991 Mar 8, 2017

Member

@soullivaneuh I think this one is not correct, this might be done on master, but not on 3x, that's a BC break.

https://github.com/sonata-project/SonataMediaBundle/blob/3.x/Controller/MediaController.php#L52

This comment has been minimized.

Copy link
@soullivaneuh

soullivaneuh Mar 8, 2017

Author Member

Oops, bad PR filters while writing the change log. I'll fix this.

This comment has been minimized.

Copy link
@soullivaneuh

soullivaneuh Mar 8, 2017

Author Member
- `MediaController::viewAction` signature to include Request as first parameter
- `MediaController::liipImagineFilterAction` signature to include Request as first parameter

### Fixed
- Optional dependency to SonataFormatterBundle is now on `^3.2`
- Fixed issue when using SonataMediaBundle blocks in conjunction with SonataPageBundle and page composer (Sonata sandbox)
- Double padding on media list

### Removed
- Removed an ugly hack to retrieve configuration on `AddProviderCompilerPass`

## [3.4.0](https://github.com/sonata-project/SonataMediaBundle/compare/3.3.1...3.4.0) - 2017-02-28
### Added
- An icon to admin menu (fa-image)
Expand Down
2 changes: 1 addition & 1 deletion DependencyInjection/Compiler/AddProviderCompilerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function process(ContainerBuilder $container)
public function fixSettings(ContainerBuilder $container)
{
@trigger_error(
'The '.__METHOD__.' method is deprecated since 3.x, to be removed in 4.0.',
'The '.__METHOD__.' method is deprecated since 3.5, to be removed in 4.0.',
E_USER_DEPRECATED
);

Expand Down
13 changes: 8 additions & 5 deletions UPGRADE-3.x.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
UPGRADE 3.x
===========

UPGRADE FROM 3.4 to 3.5
=======================

### Deprecations

Sonata\MediaBundle\DependencyInjection\Compiler\AddProviderCompilerPass::fixSettings($container)
is deprecated. Please avoid using this method, use ``getExtensionConfig($container)`` instead.

UPGRADE FROM 3.2 to 3.3
=======================

Expand Down Expand Up @@ -41,11 +49,6 @@ __construct($id, ThumbnailInterface $thumbnail, BackendInterface $backend, Event
When creating a custom video provider, you have to implement the ``getReferenceUrl`` method to establish
the media url.

### Deprecations

Sonata\MediaBundle\DependencyInjection\Compiler\AddProviderCompilerPass::fixSettings($container)
is deprecated. Please avoid using this method, use ``getExtensionConfig($container)`` instead.

UPGRADE FROM 3.0 to 3.1
=======================

Expand Down

0 comments on commit 17162cc

Please sign in to comment.