Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stimulus bundle in dependency #8222

Closed

Conversation

onEXHovia
Copy link
Contributor

@onEXHovia onEXHovia commented Dec 7, 2024

Subject

Add https://github.com/symfony/stimulus-bundle in dependency
Need for #8221 and next PRs

Changelog

### Added
- Add stimulus bundle in dependency

### Changed

### Deprecated

### Removed

### Fixed

### Security

@onEXHovia onEXHovia closed this Dec 7, 2024
@onEXHovia onEXHovia reopened this Dec 7, 2024
@onEXHovia
Copy link
Contributor Author

onEXHovia commented Dec 7, 2024

@VincentLanglet failed on 8.0, shouldn't drop PHP 8.0 support in 5.x branch?

or we do bold move for drop php 8.0 in branch 4.x if you look at the statistics https://packagist.org/packages/sonata-project/admin-bundle/php-stats PHP 8.0 percentage is too low

@VincentLanglet
Copy link
Member

Hi @onEXHovia I'm going to drop PHP 8 and symfony < 6.4 on every project
cf #8225

@onEXHovia onEXHovia force-pushed the require-stimulus-bundle branch from d8dc9a6 to ec12159 Compare December 7, 2024 17:51
@onEXHovia
Copy link
Contributor Author

Rebased

@VincentLanglet
Copy link
Member

Why is needed as dependency if it's not used yet ?
You can add it the day you'll use it, no ?

Also, we should first decide if the x-editable replacement is ok on 4.x or will be done in 5.x.
If it's in 5.x stimulus is not needed in 4.x.

@onEXHovia
Copy link
Contributor Author

Why is needed as dependency if it's not used yet ?
You can add it the day you'll use it, no ?

This package is needed because we will update what is possible in branch 4.x, for example split admin to many controllers, move inline javascript from templates to controllers and etc

Step by step will remain js/libs with serious BC, this xeditable, select2... they will already be migrate on branch 5.x with replace to other solutions. Branch 5.x will also include(in my opinion) remove jquery from dependency and full migrate from adminlte to native bootstrap without custom template(adminlte, tabler etc)

Regarding this PR if it is so critical, i can add the library in another PR when start update js.

@VincentLanglet
Copy link
Member

Regarding this PR if it is so critical, i can add the library in another PR when start update js.

Yes, I think it's better to add it in another PR when you start to update js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants