New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaceless filter is deprecated since Twig 3.12 #8214

Open

ZZromanZZ opened this issue Nov 1, 2024 · 3 comments

Labels

bug unconfirmed

ZZromanZZ commented Nov 1, 2024

Environment

Sonata packages

Does not matter

Symfony packages

Does not matter

PHP version

Does not matter

Subject

Minimal repository with the bug

Spaceless filter is used in lot of templates

Steps to reproduce

Sonata admin with Twig 3.12+

Expected results

To not use spacess filter

Actual results

ZZromanZZ added bug unconfirmed labels

Contributor

zyberspace commented Nov 1, 2024

Looks like there is no drop-in replacement:

https://twig.symfony.com/doc/3.x/filters/spaceless.html

twigphp/Twig#4236

Meaning every template that uses this, would need to be checked, so the additional whitespace doesn't cause any layout / CSS problems.

haivala commented Nov 4, 2024

this is the replacement: https://twig.symfony.com/doc/3.x/templates.html#templates-whitespace-control

Member

VincentLanglet commented Nov 13, 2024

Hi, PR is welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment