You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently for redshift and snowflake the domain_sessionid column is loaded as a char(128) when most other columns are a varchar(128). In snowflake this doesn't actually matter as snowflake does not pad the string (https://docs.snowflake.com/en/sql-reference/data-types-text#char-character-nchar) but in redshift this padding does occur, which can lead to confusion from users and edge case issues with data models, it also has a slightly higher storage cost when compared to a varchar.
Given no other columns are a char I don't foresee a reason that this needs to remain as one.
Currently for redshift and snowflake the
domain_sessionid
column is loaded as achar(128)
when most other columns are avarchar(128)
. In snowflake this doesn't actually matter as snowflake does not pad the string (https://docs.snowflake.com/en/sql-reference/data-types-text#char-character-nchar) but in redshift this padding does occur, which can lead to confusion from users and edge case issues with data models, it also has a slightly higher storage cost when compared to a varchar.Given no other columns are a
char
I don't foresee a reason that this needs to remain as one.This is everywhere I can see the definition made:
snowplow-rdb-loader/modules/redshift-loader/src/main/scala/com/snowplowanalytics/snowplow/loader/redshift/RedshiftEventsTable.scala
Line 134 in 05dd5ab
snowplow-rdb-loader/modules/snowflake-loader/src/main/scala/com/snowplowanalytics/snowplow/loader/snowflake/SnowflakeEventsTable.scala
Line 134 in 05dd5ab
snowplow-rdb-loader/modules/snowflake-loader/src/main/resources/atomic-def.sql
Line 159 in 05dd5ab
snowplow-rdb-loader/modules/snowflake-loader/src/main/scala/com/snowplowanalytics/snowplow/loader/snowflake/ast/AtomicDef.scala
Line 193 in 05dd5ab
The text was updated successfully, but these errors were encountered: