Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change domain_sessionid to be a varchar instead of a char #1324

Open
rlh1994 opened this issue Dec 1, 2023 · 0 comments
Open

Change domain_sessionid to be a varchar instead of a char #1324

rlh1994 opened this issue Dec 1, 2023 · 0 comments

Comments

@rlh1994
Copy link

rlh1994 commented Dec 1, 2023

Currently for redshift and snowflake the domain_sessionid column is loaded as a char(128) when most other columns are a varchar(128). In snowflake this doesn't actually matter as snowflake does not pad the string (https://docs.snowflake.com/en/sql-reference/data-types-text#char-character-nchar) but in redshift this padding does occur, which can lead to confusion from users and edge case issues with data models, it also has a slightly higher storage cost when compared to a varchar.

Given no other columns are a char I don't foresee a reason that this needs to remain as one.

This is everywhere I can see the definition made:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant