Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.2.3 depends on @babel/runtime == 7.0.0-beta.53 #264

Closed
jsg2021 opened this issue Jan 7, 2019 · 1 comment
Closed

Release v4.2.3 depends on @babel/runtime == 7.0.0-beta.53 #264

jsg2021 opened this issue Jan 7, 2019 · 1 comment

Comments

@jsg2021
Copy link
Contributor

jsg2021 commented Jan 7, 2019

The recent release seems to have a stale hard dependency on @babel/runtime. (no range)

As a quick fix, (until this project is updated to use the final release of babel 7), you could drop the runtime?

@jsg2021
Copy link
Contributor Author

jsg2021 commented Jan 7, 2019

I see this was the solution for a hotfix babel/runtime dropping core-js... maybe this shouldn't use the runtime transform at all and instead use rollup and keep the used runtime functions deduped at the top of the bundle. (#243)

Our build was fixed by pinning to 4.1.1.

josephfrazier added a commit to josephfrazier/xregexp that referenced this issue Jan 8, 2019
slevithan pushed a commit that referenced this issue Jan 8, 2019
Fixes #264

See #262 (comment)

See here for more info on the `@babel/plugin-transform-runtime` change:
https://babeljs.io/docs/en/next/babel-plugin-transform-runtime#corejs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant