Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Drop rate limiting prober #309

Open
haydentherapper opened this issue Dec 10, 2024 · 0 comments · May be fixed by #310
Open

Proposal: Drop rate limiting prober #309

haydentherapper opened this issue Dec 10, 2024 · 0 comments · May be fixed by #310
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

We now manage the load balancer via GCP, with rate limiting easily configured. This prober was more valuable when we configured rate limiting via nginx was a more convoluted process.

Given GitHub Actions are shared IPs and we rate limit by IP and not by identity, we also risk impacting other GitHub workflows that are concurrently running.
@haydentherapper haydentherapper added the enhancement New feature or request label Dec 10, 2024
@haydentherapper haydentherapper linked a pull request Dec 10, 2024 that will close this issue
Open
haydentherapper added a commit to haydentherapper/sigstore-probers that referenced this issue Dec 10, 2024
@haydentherapper
Remove rate limiting prober
989aa9a 
Fixes sigstore#309

Signed-off-by: Hayden Blauzvern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rate limiting prober haydentherapper/sigstore-probers
1 participant
@haydentherapper