Fix for sending scheduled local notifications #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. This does fix an issue, but it doesn't fix the overall issue with the latest API levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Method
Send(Notification notification)in android implementation ofINotificationManagerwas storing shared type ofNotificationinrepository, now it will storeAndroid Notification.Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
Now scheduled notifications should appear for the user on android platform.
Testing Procedure
Don't know what to say just try to
notificationManager.Send(notification)on android withScheduleDatewith and without this fix.I recorded also video before and after fix:
shiny.notifications-bugged.mp4
shiny.notification-fixed.mp4
PR Checklist