Azure Notification Hub integration and support for Firebase FCM API v1 #1431
-
The "old" Firebase API will stop working 20/6/2024 and so I was testing with the new API V1: I use Azure Notification Hub to send push messages to IOS and Android. This question is about the Android devices.
The problem is that the Android device registrations (that are created by Shiny) in my Azure Notification hub have the platform type "Fcm" and this should be "FCMV1" per: https://learn.microsoft.com/en-us/azure/notification-hubs/firebase-migration-rest In Shiny's AzureNotificationHubsPushProvider.cs there is only the old value "Fcm": #if APPLE This results in push messages that are only delivered if I use the old API call in the Azure Notification Hub SDK: await conn.SendNotificationAsync(nn, "tag1"); And nothing is delivered when using the new function: await conn.SendFcmV1NativeNotificationAsync(jsonBodyTest, "tag1"); Is my assumption correct and is the new Firebase API v1 registration platform type not yet supported by Shiny's Azure Notification Hub implementation? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 6 replies
-
Firebase is not used at all on the iOS side of Shiny with azure notification hubs. The android version of firebase is already up-to-date. Azure notification hubs on the server side does require you use the newer setup which they cover in their docs. For server setups, please consult the Azure notification Hubs documentation. I don't want to support those setups here. |
Beta Was this translation helpful? Give feedback.
-
GUYS - if you have opinions or things you've found that fix an issue - SEND A PR! Yes it is an easy fix, but all of the mechanisms are there to "go your own way" with the push provider.
This is the kind of attitude I don't want here. This is free code. Don't send workarounds when you could easily send a fix. |
Beta Was this translation helpful? Give feedback.
@aritchie I understand and apologize. In my previous comment above I asked for clarification as this is all new to me and I don't yet have a complete understanding of which parts owns which responsibility (Shiny, Firebase, Azure).
That was why I was asking for clarification to your initial response and closing of the discussion that Floris initiated. Your actions, to me, indicated that you did not want this fixed or changed.
I can gladly submit a PR if this is something we are allowed to fix/change in the
AzureNotificationHubsPushProvider
.Update
Seems you beat me to it :) Thank you