Failed to add rustup component: rustfmt

[cooperwalbrun]

Today, I updated my version of cargo-make from 0.36.2 to 0.36.3, and my tasks that use install_crate = { rustup_component_name = "rustfmt" } started failing with this error:

[cargo-make] ERROR - Failed to add rustup component: rustfmt

Here is a sample task:

[tasks.format]
description = "Format all source files."
install_crate = { rustup_component_name = "rustfmt" }
command = "cargo"
args = ["fmt"]

I tried cleaning my project workspace as well as running this task on a couple different projects, but nothing seems to help. Also, I still have the same version of rustfmt installed on my machine as before I ran the cargo install --force cargo-make command.

This task worked fine for me on 0.36.2, so did something change with the 0.36.3 update that could cause this? (I did not see anything in the release notes that would suggest this to be the case.) Maybe I could enable some sort of debug logging for cargo-make itself so I can get more insight into this error?

[sagiegurari]

@cooperwalbrun not sure. maybe related to #743 ?
did you specify a toolchain?

[cooperwalbrun]

Is there a way to get more log output beyond the single [cargo-make] ERROR - Failed to add rustup component: rustfmt message?

[sagiegurari]

try with -v

[cooperwalbrun]

Below I have copied some of the parts of the output related to rustfmt. I did not copy the entire output because it is very long. Let me know if I should include more.

I noticed that it mentions

[cargo-make] VERBOSE - Rustup Component: rustfmt not installed.

But I am able to run rustfmt --version command (and cargo fmt), so it seems to be unable to detect whether rustfmt is available? I could not find any other ERROR or WARN logs other than the very last 2 lines below.

Log Snippet

...
[cargo-make] VERBOSE - Created execution plan: ExecutionPlan {
    steps: [
        Step {
            name: "legacy-migration",
            config: Task {
                clear: None,
                description: Some(
                    "Migrates deprecated environment variables.",
                ),
                category: Some(
                    "Deprecated",
                ),
                disabled: None,
                private: Some(
                    true,
                ),
                deprecated: None,
                extend: None,
                workspace: None,
                plugin: None,
                watch: None,
                condition: Some(
                    TaskCondition {
                        fail_message: None,
                        profiles: None,
                        platforms: None,
                        channels: None,
                        env_set: None,
                        env_not_set: None,
                        env: None,
                        env_true: Some(
                            [
                                "CARGO_MAKE_RUN_DEPRECATED_MIGRATION",
                            ],
                        ),
                        env_false: None,
                        env_contains: None,
                        rust_version: None,
                        files_exist: None,
                        files_not_exist: None,
                        files_modified: None,
                    },
                ),
                condition_script: None,
                ignore_errors: None,
                force: None,
                env_files: None,
                env: Some(
                    {
                        "CARGO_MAKE_RUN_DEPRECATED_MIGRATION": Boolean(
                            false,
                        ),
                    },
                ),
                cwd: None,
                alias: None,
                linux_alias: None,
                windows_alias: None,
                mac_alias: None,
                install_crate: None,
                install_crate_args: None,
                install_script: None,
                command: None,
                args: None,
                script: Some(
                    SingleLine(
                        "#!@duckscript\nfn <scope> migrate_env\n    new_var = get_env ${1}\n    old_var = get_env ${2}\n\n    if is_defined old_var\n        echo Old environment variable ${2} detected, please use ${1} instead.\n        set_env ${1} ${old_var}\n    else if is_defined new_var\n        set_env ${2} ${new_var}\n    end\nend\n\nmigrate_env CARGO_MAKE_TEST_USE_MULTI_TEST_PHASES CARGO_MAKE_TEST_USE_MUTLI_TEST_PHASES\n",
                    ),
                ),
                script_runner: None,
                script_runner_args: None,
                script_extension: None,
                run_task: None,
                dependencies: None,
                toolchain: None,
                linux: None,
                windows: None,
                mac: None,
            },
        },
        Step {
            name: "init",
            config: Task {
                clear: None,
                description: Some(
                    "By default this task is invoked at the start of every cargo-make run.",
                ),
                category: Some(
                    "Hooks",
                ),
                disabled: None,
                private: None,
                deprecated: None,
                extend: None,
                workspace: None,
                plugin: None,
                watch: None,
                condition: None,
                condition_script: None,
                ignore_errors: None,
                force: None,
                env_files: None,
                env: None,
                cwd: None,
                alias: None,
                linux_alias: None,
                windows_alias: None,
                mac_alias: None,
                install_crate: None,
                install_crate_args: None,
                install_script: None,
                command: None,
                args: None,
                script: None,
                script_runner: None,
                script_runner_args: None,
                script_extension: None,
                run_task: None,
                dependencies: None,
                toolchain: None,
                linux: None,
                windows: None,
                mac: None,
            },
        },
        Step {
            name: "install-rustfmt",
            config: Task {
                clear: None,
                description: Some(
                    "Installs cargo rustfmt plugin.",
                ),
                category: Some(
                    "Development",
                ),
                disabled: None,
                private: None,
                deprecated: None,
                extend: None,
                workspace: None,
                plugin: None,
                watch: None,
                condition: None,
                condition_script: None,
                ignore_errors: None,
                force: None,
                env_files: None,
                env: Some(
                    {
                        "CFG_RELEASE": Conditional(
                            EnvValueConditioned {
                                value: "${CARGO_MAKE_RUST_VERSION}",
                                condition: Some(
                                    TaskCondition {
                                        fail_message: None,
                                        profiles: None,
                                        platforms: None,
                                        channels: None,
                                        env_set: None,
                                        env_not_set: Some(
                                            [
                                                "CFG_RELEASE",
                                            ],
                                        ),
                                        env: None,
                                        env_true: None,
                                        env_false: None,
                                        env_contains: None,
                                        rust_version: None,
                                        files_exist: None,
                                        files_not_exist: None,
                                        files_modified: None,
                                    },
                                ),
                            },
                        ),
                        "CFG_RELEASE_CHANNEL": Conditional(
                            EnvValueConditioned {
                                value: "${CARGO_MAKE_RUST_CHANNEL}",
                                condition: Some(
                                    TaskCondition {
                                        fail_message: None,
                                        profiles: None,
                                        platforms: None,
                                        channels: None,
                                        env_set: None,
                                        env_not_set: Some(
                                            [
                                                "CFG_RELEASE_CHANNEL",
                                            ],
                                        ),
                                        env: None,
                                        env_true: None,
                                        env_false: None,
                                        env_contains: None,
                                        rust_version: None,
                                        files_exist: None,
                                        files_not_exist: None,
                                        files_modified: None,
                                    },
                                ),
                            },
                        ),
                    },
                ),
                cwd: None,
                alias: None,
                linux_alias: None,
                windows_alias: None,
                mac_alias: None,
                install_crate: Some(
                    CrateInfo(
                        InstallCrateInfo {
                            crate_name: "rustfmt-nightly",
                            rustup_component_name: Some(
                                "rustfmt",
                            ),
                            binary: "rustfmt",
                            test_arg: TestArg {
                                inner: [
                                    "--help",
                                ],
                            },
                            min_version: None,
                            version: None,
                            install_command: None,
                            force: None,
                        },
                    ),
                ),
                install_crate_args: None,
                install_script: None,
                command: None,
                args: None,
                script: None,
                script_runner: None,
                script_runner_args: None,
                script_extension: None,
                run_task: None,
                dependencies: None,
                toolchain: None,
                linux: None,
                windows: None,
                mac: None,
            },
        },
        Step {
            name: "format",
            config: Task {
                clear: None,
                description: Some(
                    "Format all source files.",
                ),
                category: Some(
                    "Development",
                ),
                disabled: None,
                private: None,
                deprecated: None,
                extend: None,
                workspace: None,
                plugin: None,
                watch: None,
                condition: None,
                condition_script: None,
                ignore_errors: None,
                force: None,
                env_files: None,
                env: Some(
                    {
                        "CARGO_MAKE_CURRENT_TASK_INITIAL_MAKEFILE": Value(
                            "~/projects/rust-template/Makefile.toml",
                        ),
                        "CARGO_MAKE_CURRENT_TASK_INITIAL_MAKEFILE_DIRECTORY": Value(
                            "~/projects/rust-template",
                        ),
                    },
                ),
                cwd: None,
                alias: None,
                linux_alias: None,
                windows_alias: None,
                mac_alias: None,
                install_crate: Some(
                    RustupComponentInfo(
                        InstallRustupComponentInfo {
                            rustup_component_name: "rustfmt",
                            binary: None,
                            test_arg: None,
                        },
                    ),
                ),
                install_crate_args: None,
                install_script: None,
                command: Some(
                    "cargo",
                ),
                args: Some(
                    [
                        "fmt",
                    ],
                ),
                script: None,
                script_runner: None,
                script_runner_args: None,
                script_extension: None,
                run_task: None,
                dependencies: Some(
                    [
                        Name(
                            "install-rustfmt",
                        ),
                    ],
                ),
                toolchain: Some(
                    Simple(
                        "${CARGO_MAKE_RUST_DEFAULT_TOOLCHAIN}",
                    ),
                ),
                linux: None,
                windows: None,
                mac: None,
            },
        },
        Step {
            name: "end",
            config: Task {
                clear: None,
                description: Some(
                    "By default this task is invoked at the end of every cargo-make run.",
                ),
                category: Some(
                    "Hooks",
                ),
                disabled: None,
                private: None,
                deprecated: None,
                extend: None,
                workspace: None,
                plugin: None,
                watch: None,
                condition: None,
                condition_script: None,
                ignore_errors: None,
                force: None,
                env_files: None,
                env: None,
                cwd: None,
                alias: None,
                linux_alias: None,
                windows_alias: None,
                mac_alias: None,
                install_crate: None,
                install_crate_args: None,
                install_script: None,
                command: None,
                args: None,
                script: None,
                script_runner: None,
                script_runner_args: None,
                script_extension: None,
                run_task: None,
                dependencies: None,
                toolchain: None,
                linux: None,
                windows: None,
                mac: None,
            },
        },
    ],
}
...
[cargo-make] VERBOSE - Running Task: install-rustfmt
[cargo-make] VERBOSE - Setting Up Env.
[cargo-make] VERBOSE - Setting env: CFG_RELEASE = Conditional(
    EnvValueConditioned {
        value: "${CARGO_MAKE_RUST_VERSION}",
        condition: Some(
            TaskCondition {
                fail_message: None,
                profiles: None,
                platforms: None,
                channels: None,
                env_set: None,
                env_not_set: Some(
                    [
                        "CFG_RELEASE",
                    ],
                ),
                env: None,
                env_true: None,
                env_false: None,
                env_contains: None,
                rust_version: None,
                files_exist: None,
                files_not_exist: None,
                files_modified: None,
            },
        ),
    },
)
...
[cargo-make] VERBOSE - Rustup Component: rustfmt not installed.
[cargo-make] VERBOSE - Failed to add component: rustfmt via rustup
[cargo-make] ERROR - Failed to add rustup component: rustfmt
[cargo-make] WARN - Build Failed.

[sagiegurari]

@cooperwalbrun sorry for late reply (harder to watch discussions compared to issues).
ya, the log doesn't show relevant stuff, probably didn't write anything... :(
i have to admit that its hard for me to reproduce the issue so i can't give much insights.
if there is an easy way to reproduce i would love to get instructions (in an issue), so i can try it out. i can spin a clean gitpod machine to try it.

[cooperwalbrun]

Alright, I have not had a chance to try it on a different machine but I will and if I am able to reproduce it consistently in any way, I will file an issue. Until then, I will mark this discussion as resolved. Thanks for all the help!