-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use explicit anchors #657
Comments
Even better would be a workflow file that ensured that every section and sub-section had an explicit anchor. That could be integrated as part of the general PR workflow. @maelle How about i write a script for that, let you know when that's done, and you can plug it in to the workflow? |
Oh good catch @eliocamp! @mpadge Yep but first I'll make a bigger PR ensuring current content has such explicit references. For my own reference: https://quarto.org/docs/authoring/cross-references.html#sections |
I've done some work on this, right now I have one (last?) blocker which is that titles à la |
this is only a problem for the bot cheatsheet. Maybe we don't need explicit cross-references for it, or maybe it wouldn't be horrible to have numbers there. |
|
@mpadge note that I need to be working on a PR workflow anyway.
this works if all languages have the same XML structure (header, paragraphs) -- which this work on anchors helped check. |
In reviewing the Spanish translation I've found this instance of a section without explicit anchor. An earlier section links to this one using the implicit anchor created by rmarkdown/quarto, but the link broke in the Spanish version because the name of the implicit anchor is now different.
dev_guide/softwarereview_intro.Rmd
Line 52 in 6bee2f7
Before sending a PR to address this particular case, perhaps it might be better to do a holistic revision to add explicit anchors to every section in one single PR.
The text was updated successfully, but these errors were encountered: