Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risedev psql quit when Ctrl-C once #12558

Open
TennyZhuang opened this issue Sep 27, 2023 · 8 comments
Open

risedev psql quit when Ctrl-C once #12558

TennyZhuang opened this issue Sep 27, 2023 · 8 comments
Assignees
Labels
priority/low type/bug Something isn't working
Milestone

Comments

@TennyZhuang
Copy link
Contributor

Describe the bug

image

Error message/log

No response

To Reproduce

./risedev psql

Expected behavior

image

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@TennyZhuang TennyZhuang added type/bug Something isn't working priority/low labels Sep 27, 2023
@github-actions github-actions bot added this to the release-1.3 milestone Sep 27, 2023
@xxchan
Copy link
Member

xxchan commented Sep 28, 2023

Interesting

@xxchan
Copy link
Member

xxchan commented Sep 28, 2023

I guess this is because cargo-make runs script in a child process, and thus signal handling is not considered.

@BugenZhao
Copy link
Member

+1. This is kind of annoying.

@kwannoel
Copy link
Contributor

kwannoel commented Oct 7, 2023

Saw that @xxchan opened an issue in the cargo-make repo. Will wait for updates on that. Thanks @xxchan!

sagiegurari/cargo-make#954

@xxchan xxchan modified the milestones: release-1.5, release-1.6 Dec 4, 2023
@xxchan xxchan modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@kwannoel
Copy link
Contributor

Can use this instead #15294 to launch psql

@xxchan xxchan modified the milestones: release-1.7, future-release-1.9 Mar 6, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@wangrunji0408
Copy link
Contributor

wangrunji0408 commented Jul 25, 2024

Any updates? -- by Tenny

@xxchan
Copy link
Member

xxchan commented Jul 25, 2024

Didn't have a chance to do sagiegurari/cargo-make#954 yet. 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants