New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oval tool filling pixels incorrectly for oblong shapes #48

Open

Cody811 opened this issue Jan 20, 2021 · 1 comment

Labels

bug

Cody811 commented Jan 20, 2021

The oval shape is filling incorrect pixels along the X axis

X=2 Y=1

X=5, Y=1

X=6, Y=3

Y=3. X=6

Collaborator

theabbie commented Jan 20, 2021

@Cody811 Might be an issue in algorithm, we will fix it, Thanks.

PixelCraft/lib/Shapes.js

Line 134 in cf69d93

function ellipse(rx, ry, pc){

theabbie added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment