Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme: double magnifying glass on iOS #118

Open
m-aciek opened this issue Mar 18, 2023 · 2 comments
Open

Dark theme: double magnifying glass on iOS #118

m-aciek opened this issue Mar 18, 2023 · 2 comments

Comments

@m-aciek
Copy link
Contributor

m-aciek commented Mar 18, 2023

Big thank you for the work on dark theme (#44), I love the changes. I found minor bug while testing the updated styles on different devices.

On iOS, in both Chrome and Safari there's double magnifier glass shown near to the search box.

iOS 16.3.1, (Chrome 111.0.5563.72)
cc @septatrix

@septatrix
Copy link
Contributor

It is probably one of the following pseudo elements, if I were to guess probably the first:

input[type="search"]::-webkit-search-decoration
input[type="search"]::-webkit-search-cancel-button
input[type="search"]::-webkit-search-results-button
input[type="search"]::-webkit-search-results-decoration

It should be possible to hide it by applying a display: none; to the respective element. Or we could remove the search icon added by ourselves (how it is currently in the desktop search bar) and leave safari alone. Depends on what most people prefer.

@m-aciek
Copy link
Contributor Author

m-aciek commented Mar 22, 2023

My intuitional preference would be to just hide the browser-native icon to maintain the same interface across different machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants