Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requires-python #62

Open
ucodery opened this issue Oct 31, 2024 · 5 comments · May be fixed by #63
Open

Remove requires-python #62

ucodery opened this issue Oct 31, 2024 · 5 comments · May be fixed by #63

Comments

@ucodery
Copy link

ucodery commented Oct 31, 2024

This copier always sets requires-python = ">=3.10", but it doesn't know what versions of python the (yet-to-be-crated) package will be compatible with.

Yes 3.10 is the lowest in-support version, but this is overly-restrictive to users. Especially for use in our tutorials, which use some very vanilla Python that would work all the way back to 3.3 I'd bet.

@Midnighter
Copy link
Contributor

@blink1073 mentioned that myst requires 3.10

@ucodery ucodery linked a pull request Oct 31, 2024 that will close this issue
@ucodery
Copy link
Author

ucodery commented Oct 31, 2024

Ah, so maybe conditional on {%- elif documentation == "sphinx" %}, which brings in the myst dep?

@lwasser
Copy link
Member

lwasser commented Oct 31, 2024

Oh! This comes from myst? This requirement tripped some people up who were trying to install their package into an existing envt that ran 3.9!

@ucodery
Copy link
Author

ucodery commented Oct 31, 2024

Also, this is adding an install floor to the project for a documentation dependency. At best, it should be a requirement of tool.hatch.envs.docs

@willingc
Copy link

Some discussion about classifiers: https://discuss.python.org/t/handling-stale-python-version-classifiers-for-low-churn-projects/66537/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants