-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): section header validation #2329
base: main
Are you sure you want to change the base?
Conversation
Can you replace "grandfathered" with "legacy" or something if that's what you mean here? |
Done. By the way, the tests are only failing due to GitHub rate limits, there isn't anything actually wrong with the PR, it should be fine to merge. For some reason it seems the tests attempt to pull a ton of PRs, not sure why however. |
Ah, I think that is an issue for @danderson. |
Are we able to merge in the meantime and create a follow up issue? |
gon.pk
gon.pk
@simon-friedberger Linter has been updated to now validate section headers. I forgot the linter was actually in Python, not Go, so that made it much easier! This PR is ready to merge unless you have any other comments. (The failing test is only due to the GitHub rate limits as I said before) |
Damn, sorry. This is the legacy linter that we are replacing with the Go one. We don't want to update that anymore. |
Ah. Should we remove this linter all together? I'll see if I can implement the same functionality into the Go linter. |
Yes, we should remove it. It's just here until someone puts in the work to make sure psltool covers the same things. |
This PR just fixes a few formatting issues (mostly just errors) in the PSL, as well as updating a couple links (mainly ones that were invalid/missing).