Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

服务预热代码review意见 #558

Open
andrewshan opened this issue Sep 14, 2024 · 0 comments
Open

服务预热代码review意见 #558

andrewshan opened this issue Sep 14, 2024 · 0 comments
Labels
question Further information is requested

Comments

@andrewshan
Copy link
Member

andrewshan commented Sep 14, 2024

  • 动态权限调整的过程调整成首次触发+异步的方式进行

    • Instance对象新增动态权重字段
    • 首次调用时进行动态权重的计算(这里要注意加锁保证高并发时不会同时计算影响性能)
    • 可以在ServiceInstances中记录是否已经计算过动态权重的标识
    • 后续调用则使用已经计算好的动态权重进行负载均衡
    • 如果动态权重规则有刷新,则清理掉ServiceInstances中的标识
  • 优雅上下线规则生效方式

    • 控制台有规则:使用控制台。
    • 控制台没有规则:使用SDK本地配置(polaris.yaml)。如果是在SCT框架下,则使用SCT修改后的polaris.yaml
  • HttpLosslessActionProvider 在polaris-java中有点割裂,是不是做成,如果用户传入的LosslessActionProvider为空,则默认使用HttpLosslessActionProvider,另外HttpLosslessActionProvider看看改名为DefaultLosslessActionProvider

  • com.tencent.polaris.plugin.lossless.common.HttpLosslessActionProvider#strategy,没有使用到,是不是漏了实现?

@andrewshan andrewshan added the question Further information is requested label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant