Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using externals section of config.json #309

Closed
SteveClements opened this issue May 21, 2019 · 4 comments
Closed

Using externals section of config.json #309

SteveClements opened this issue May 21, 2019 · 4 comments

Comments

@SteveClements
Copy link

Category

[ ] Enhancement

[ ] Bug

[X] Question

Version

Please specify what version of the library you are using: [1.11.0]

Question
I'd like to be able to leverage the externals section of the config.json file when using this package.
But i can't see which file for the spfx-controls-react package to reference.
As a starter i tried just to add pnp/js in as detailed here.
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/use-sp-pnp-js-with-spfx-web-parts#deploy-to-production

I've also tried this

"@pnp/pnpjs": {
      "path": "https://cdnjs.cloudflare.com/ajax/libs/pnp-pnpjs/1.0.1/pnpjs.es5.umd.bundle.min.js",
      "globalName": "pnp"
    }

But neither work and I get an error in the part saying @pnp/js could not be loaded.

Any ideas how i can use this package and reference the files externally?

Thanks!

@ghost
Copy link

ghost commented May 21, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label May 21, 2019
@michaelmaillot
Copy link
Collaborator

Hi @SteveClements,

Are you still looking for help about this one?

The page you're refering to has been updated since, so I'm not sure that it will guide you regarding your question.

However, there's an article that could help you about using external libraries in an SPFx project.

Regarding your question about using SPFx Controls as an external package, here's the CDN: https://www.jsdelivr.com/package/npm/@pnp/spfx-controls-react.

Hope that it helps.

@ghost
Copy link

ghost commented Aug 28, 2023

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within next 7 days of this comment. Thank you for your contributions to SharePoint Developer activities.

@ghost ghost closed this as completed Sep 4, 2023
@ghost
Copy link

ghost commented Sep 4, 2023

Closing issue due no response from original author. If this issue is still occurring, please open a new issue with additional details. Notice that if you have included another related issue as additional comment on this, please open that also as separate issue, so that we can track it independently.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants