Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamicForm] Creating a document set sometimes throws a 409 save conflict. #1919

Open
martinlingstuyl opened this issue Dec 10, 2024 · 2 comments · Fixed by #1920
Open

[DynamicForm] Creating a document set sometimes throws a 409 save conflict. #1919

martinlingstuyl opened this issue Dec 10, 2024 · 2 comments · Fixed by #1920
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@martinlingstuyl
Copy link
Contributor

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.20]

Expected / Desired Behavior / Question

When creating a document set using a dynamic form, this should just work.

Observed Behavior

For some tenants, and only sometimes, a 409 save conflict exception is thrown when submitting the form. It appears the folder is created still, but not updated to be a docset with all the filled in metadata.

image

The issue occurs on this line:

const iur = await library.items.getById(folderId).update(objects);

Steps to Reproduce

It's hard to reproduce unfortunately. My customer has it all the time (in two M365 tenants), but in my tenant I haven't seen the issue occur yet.

Fix

What we could do is add some intelligence to retry updating the list item based on the error that's returned.

@martinlingstuyl
Copy link
Contributor Author

Hi guys, I'm not sure if you like my implementation, but I needed to do fix this for a customer, so I've created a PR for it as well. Let me know if you've got thoughts on how this could be better. I know it's problematic because the issue is so hard to reproduce reliably.

martinlingstuyl added a commit to martinlingstuyl/sp-dev-fx-controls-react that referenced this issue Dec 10, 2024
martinlingstuyl added a commit to martinlingstuyl/sp-dev-fx-controls-react that referenced this issue Dec 11, 2024
joelfmrodrigues added a commit that referenced this issue Dec 11, 2024
Adds retry to updating list item in DynamicForm. Closes #1919
@joelfmrodrigues joelfmrodrigues added the status:fixed-next-drop Issue will be fixed in upcoming release. label Dec 11, 2024
@joelfmrodrigues joelfmrodrigues added this to the 3.21.0 milestone Dec 11, 2024
@joelfmrodrigues
Copy link
Collaborator

PR merged and will be fixed in the next release. The fix will be available in the beta release within a few minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
2 participants