Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributions display twice on mapbox #7075

Closed
archmoj opened this issue Aug 8, 2024 · 8 comments
Closed

Attributions display twice on mapbox #7075

archmoj opened this issue Aug 8, 2024 · 8 comments
Assignees
Labels
bug something broken P1 needs immediate attention

Comments

@archmoj
Copy link
Contributor

archmoj commented Aug 8, 2024

Screenshot from 2024-08-08 10-58-56

The image tests are failing on master after merging #7060: https://app.circleci.com/pipelines/github/plotly/plotly.js/10950/workflows/2c1cc796-b8cd-47b9-adcc-328d0ae4a9f2/jobs/242299/parallel-runs/0/steps/0-102

This is not related to #7060 itself since if I checkout v2.34.0

git checkout tags/v2.34.0 && npm ci && npm start

then

npm run baseline mapbox_0

Gives me the baseline with duplicate source attribution!

I suspect this was related to the order of rendering on CI but somehow wasn't noticed before.

@archmoj archmoj added the bug something broken label Aug 8, 2024
@archmoj
Copy link
Contributor Author

archmoj commented Aug 8, 2024

Re-running CircleCi tests on the same commit also confirms that something is changed on the mapbox side in the past two weeks that caused these tests to start failing.

Screenshot from 2024-08-08 12-30-40

@archmoj
Copy link
Contributor Author

archmoj commented Aug 8, 2024

Strangely enough if I call

python3 test/image/make_baseline.py mapbox_0

It works just fine.
But

npm run baseline mapbox_0

fails although it calls the same python script using node.js!

🤯

@archmoj
Copy link
Contributor Author

archmoj commented Aug 8, 2024

@birkskyum this issue doesn't seem related to your PR; although it start showing up after we merged the maplibre PR.

Anyway I was not able to figure out what causes this.
Please note that in addition to the image test, there is one jasmine test is failing which might be easier for debugging.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2024

Re-running CircleCi tests on the same commit also confirms that something is changed on the mapbox side in the past two weeks that caused these tests to start failing.

Screenshot from 2024-08-08 12-30-40

@birkskyum Yes the same commit before merging maplibre PR passed the tests.
But then few days later it start failing!!

@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2024

The issues are also present in the existing builds, like the examples: https://plotly.com/python/mapbox-layers/

Could you send a screenshot?
I don't see duplicates there.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2024

@birkskyum That looks like a different bug. No?

@birkskyum
Copy link
Contributor

birkskyum commented Aug 9, 2024

@archmoj , yes, maybe separate but can't say for sure. I made a ticket for that and removed the noise about it from this ticket.

@gvwilson gvwilson added the P1 needs immediate attention label Aug 9, 2024
@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2024

I skipped those mapbox tests on CI in #7083.
And I close this issue for now.

@archmoj archmoj closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P1 needs immediate attention
Projects
None yet
Development

No branches or pull requests

3 participants