Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logarithmic scatter axis tick labels, avoid overlapping text #6105

Open
jensb opened this issue Feb 4, 2022 · 4 comments
Open

improve logarithmic scatter axis tick labels, avoid overlapping text #6105

jensb opened this issue Feb 4, 2022 · 4 comments
Labels
feature something new P2 needed for current cycle

Comments

@jensb
Copy link

jensb commented Feb 4, 2022

Hello,

I created a patch for Plotly which impvoes display of axis tick labels for logarithmic axes of scatter plots.
More preciesly, it avoids overlapping labels much better (IMHO) than before.

The issue and the patch is described in more detail here:
https://stackoverflow.com/questions/70926979/skip-overlapping-tick-labels-in-plotly-javascript/70953790#70953790

Do you think this has a chance to be merged? Then I'll create a PR for the master branch.
If this needs more work, please advise.

Thank you!

@archmoj
Copy link
Contributor

archmoj commented Feb 7, 2022

That looks interesting.
Looking forward to reviewing your PR.

@jensb
Copy link
Author

jensb commented Feb 15, 2022

Sure!
However, I need to ask for some assistance.

I set up the devel environment and I can run npm start to boot up. But on the first Tabs.reload() I get a syntax error in plotly.js. This is the offending line:

image

This is how the line looks after the first Tabs.reload():

image

There seems to be a charset issue in the reload feature.
What am I doing going wrong?

I'm using Chrome 98.0.4758.80 on Linux, as well as NPM 8.3.1, Node 16.14.0.

@jensb
Copy link
Author

jensb commented Feb 15, 2022

I managed to patch Plotly anyway: #6120

@jensb
Copy link
Author

jensb commented Mar 9, 2022

Any comments, progress, review?
Anything I need to do to help merging this?
Yes, there are some failing tests, but this is obviously because I am (slightly) changing Plotly's behaviour, intentionally ... for the better, I hope.

@gvwilson gvwilson self-assigned this Jun 26, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson changed the title [PATCH] Improvement for logarithmic scatter axis tick labels, avoid overlapping text improve logarithmic scatter axis tick labels, avoid overlapping text Aug 9, 2024
@gvwilson gvwilson added feature something new P2 needed for current cycle labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P2 needed for current cycle
Projects
None yet
Development

No branches or pull requests

3 participants