Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use let and const for docs? #119

Open
jxu opened this issue Jun 7, 2021 · 3 comments
Open

Use let and const for docs? #119

jxu opened this issue Jun 7, 2021 · 3 comments

Comments

@jxu
Copy link

jxu commented Jun 7, 2021

Does plotly assume ES6 support? Should let and const be used in the docs for modern practice because var has some tricky pitfalls?

@nicolaskruchten
Copy link
Contributor

We do not assume ES6 although your suggestion is probably a good one. We would accept a PR that made this change :)

@jxu
Copy link
Author

jxu commented Jun 8, 2021

I don't know if the docs should use let if we cannot guarantee ES6 support. The change would affect pretty much every single page which is a lot, though I noticed some code already uses ES6 arrow functions so those have to have ES6 already.

@nicolaskruchten
Copy link
Contributor

We'd probably accept some big standardizing PRs yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants