-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate InvalidCallbackReturnValue
size
#2658
Comments
Great point! Feel like creating a PR? we should probably keep the existing behavior for reasonably-sized objects, but then past some size (1000 chars?) truncate and say something like |
Sure, why not? Anything can be done; but please give me your (repo's) requirements:
Maybe I can donate that even tomorrow. |
Excellent, thank you in advance 😎
As simple as possible while getting the job done. Particularly in error handling, short & readable code is more important to us than performance.
Thinking about this more, since this error is always about a bad type we don't need that many characters, just enough to help you find the object in your code. So maybe 100 characters, then yes, |
Truncate the stringified value of `bad_val`, in order to avoid excessive output on the debug pop-up. Fixes plotly#2658 Signed-off-by: Stavros Ntentos <[email protected]>
The simplest one would've been and 🙃 I have sent my review - I hope it is straightforward. |
Truncate the stringified value of `bad_val`, in order to avoid excessive output on the debug pop-up. Fixes plotly#2658 Signed-off-by: Stavros Ntentos <[email protected]>
Truncate the stringified value of `bad_val`, in order to avoid excessive output on the debug pop-up. Fixes plotly#2658 Signed-off-by: Stavros Ntentos <[email protected]>
InvalidCallbackReturnValue
size?InvalidCallbackReturnValue
size
Would you consider truncating/ellipsisizing the
{bad_val}
output ofhttps://github.com/plotly/dash/blob/c729ef82e179623592d033929126f284837fd178/dash/_validate.py#L238C26-L253
?
Sometimes the output can be humongous, which affects browser rendering 😕
The text was updated successfully, but these errors were encountered: