Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRowStyle does not update the style in a callback #236

Open
AnnMarieW opened this issue Aug 29, 2023 · 4 comments
Open

getRowStyle does not update the style in a callback #236

AnnMarieW opened this issue Aug 29, 2023 · 4 comments
Labels
documentation written for humans feature something new P3 not needed for current cycle

Comments

@AnnMarieW
Copy link
Collaborator

When you update the getRowStyle prop in a callback, the style is not applied unless the grid or the page is refreshed.

The issue and the workaround is posted here on the forum

@BSd3v
Copy link
Collaborator

BSd3v commented Aug 31, 2023

I'm not sure if there is a way to allow for this, as this most likely pertains to the underlying grid and how it functions.

@AnnMarieW
Copy link
Collaborator Author

AnnMarieW commented Aug 31, 2023

Could we add the redrawRows() method like in the clientside callback in the workaround example on the forum as posted above? That would make it unnecessary for everyone to add that callback to their apps.

@BSd3v
Copy link
Collaborator

BSd3v commented Sep 28, 2023

Revisiting this, I've used the redrawRows() a couple of times, this use-case makes more sense then some of the others I've used it for to automatically have the grid perform this.. My only concern is with things like infinite scroll or massive grid's that could cause issues.

For example, think of something like adjusting conditional formatting:

User makes changes to conditions <200 rows, dev opts to render the changes immediately, >=200 rows, dev allows user to opt to make these changes right now, or the next time they render the grid. Which at any point they have the ability to use a render button on the page that reloads the data from the server or uses the redraw method.

I dont think we should say that it happens this way immediately for the result of some unexpected behaviour.

We could potentially have something in there where we give the option for the dev to say have upon these events, redraw the rows, that way the dev has more control over unexpected side effects.

@AnnMarieW
Copy link
Collaborator Author

Good points. The clientside callback for redrawRows is pretty simple. Maybe adding some use cases and examples to the docs is all that's needed.

@BSd3v BSd3v added the documentation written for humans label Oct 13, 2023
@BSd3v BSd3v changed the title [Bug] - getRowStyle does not update the style in a callback getRowStyle does not update the style in a callback Oct 13, 2023
@gvwilson gvwilson assigned gvwilson and unassigned gvwilson Jul 27, 2024
@gvwilson gvwilson added feature something new P3 not needed for current cycle labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation written for humans feature something new P3 not needed for current cycle
Projects
None yet
Development

No branches or pull requests

3 participants