-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColorKeyword.fs issues #459
Comments
Hey @GarryPatchett thanks for reporting this, it is indeed not intended, at least not the spelling mistakes. I tried to go with .NET naming convention regarding the capitalization, and since DUs cannot be lowercase in F# anyways, we cannot name them with a 100% match.
To keep the current version backwards-compatible, the way to go would be adding the correctly named cases and keeping the wrong ones (with an If you want to try and cook up a PR that'd be awesome, otherwise i'll pick this up in the somewhat near future 😉 |
Thanks for getting in touch. My experience with Git/GitHub is very limited and I would be worried that I would make some horrible mistake and ruin things, and don’t really want to risk messing up such important code. I’m happy to leave this to someone who knows what they are doing rather than me blundering around, bumping into the furniture and knocking expensive vases to the floor. I’d be happy to learn how to do it but that would probably lead to a lot of step-by-step ‘hand-holding’ which may not be the best use of someone else’s time. |
Description
There are some colour keywords in Plotly.NET/CommonAbstractions/ColorKeyword.fs that I think are slightly wrong, in relation to how they are here: https://www.w3schools.com/colors/colors_names.asp
The list below shows: existing name – proposed name (reason for reporting).
Darkolivegreen – DarkOliveGreen (Capitalisation)
Honeydew – HoneyDew (Capitalisation)
Hotpink – HotPink (Capitalisation)
LightAalmon – LightSalmon (Spelling)
LightAeaGreen – LightSeaGreen (Spelling)
LightAkyBlue – LightSkyBlue (Spelling)
LightAlateGray – LightSlateGray (Spelling)
LightslateGrey – LightSlateGrey (Capitalisation, and repeated as LightAlateGray, and missing from ofRGB function)
Skyblue -SkyBlue (Capitalisation)
I don’t know the best way to ‘fix’ these but I thought I’d mention it.
Related information
The text was updated successfully, but these errors were encountered: