-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing setting scope properties like mathjax #99
Labels
bug
something broken
feature
something new
P3
not needed for current cycle
performance
something is slow
Comments
Thanks for bringing this up @AbdealiJK, Yeah, I think we could just check whether the new value is a change and only restart if the url changed. |
Created a quick PR for this: #100 |
gvwilson
added
bug
something broken
P3
not needed for current cycle
performance
something is slow
labels
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
something broken
feature
something new
P3
not needed for current cycle
performance
something is slow
I found out after hours of debugging, that my write_image() in plotly had become significant slower.
I realized that this was happening because I had added:
pio.kaleido.scope.mathjax = with_mathjax
at some point inside a for loopafter a bunch of debugging, I found:
https://github.com/plotly/Kaleido/blob/v0.1.0/repos/kaleido/py/kaleido/scopes/plotly.py#L150
i.e. every time this property is set, the plotly server gets shutdown. Which was causing my code to run about 10x slower.
It would be great if we could set this up so that the shutdown is only triggered if required
The text was updated successfully, but these errors were encountered: