Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing setting scope properties like mathjax #99

Open
AbdealiLoKo opened this issue Jul 17, 2021 · 2 comments · May be fixed by #100
Open

Optimizing setting scope properties like mathjax #99

AbdealiLoKo opened this issue Jul 17, 2021 · 2 comments · May be fixed by #100
Labels
bug something broken feature something new P3 not needed for current cycle performance something is slow

Comments

@AbdealiLoKo
Copy link

I found out after hours of debugging, that my write_image() in plotly had become significant slower.
I realized that this was happening because I had added: pio.kaleido.scope.mathjax = with_mathjax at some point inside a for loop

after a bunch of debugging, I found:
https://github.com/plotly/Kaleido/blob/v0.1.0/repos/kaleido/py/kaleido/scopes/plotly.py#L150

i.e. every time this property is set, the plotly server gets shutdown. Which was causing my code to run about 10x slower.
It would be great if we could set this up so that the shutdown is only triggered if required
@jonmmease jonmmease added the feature something new label Jul 21, 2021
@jonmmease
Copy link
Collaborator

Thanks for bringing this up @AbdealiJK,

Yeah, I think we could just check whether the new value is a change and only restart if the url changed.

@AbdealiLoKo AbdealiLoKo linked a pull request Jul 23, 2021 that will close this issue
Open
@AbdealiLoKo
Copy link
Author

Created a quick PR for this: #100

@gvwilson gvwilson self-assigned this Jul 26, 2024
@gvwilson gvwilson removed their assignment Aug 3, 2024
@gvwilson gvwilson added bug something broken P3 not needed for current cycle performance something is slow labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken feature something new P3 not needed for current cycle performance something is slow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scope: Restart kaleido only if properties change AbdealiLoKo/Kaleido
3 participants
@gvwilson @AbdealiLoKo @jonmmease