Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working without passing CMSampleBuffer #26

Open
chaudharyvivek opened this issue Mar 4, 2022 · 12 comments
Open

Not working without passing CMSampleBuffer #26

chaudharyvivek opened this issue Mar 4, 2022 · 12 comments

Comments

@chaudharyvivek
Copy link

This works fine when I am passing CMSampleBuffer using deliverRecordedData. But in some case, I want it to handle automatically like GoogleWebRTC does. So this is not working for me without passing the sample buffer.

@akihikodaki
Copy link
Contributor

It is a limitation of iOS.

@chaudharyvivek
Copy link
Author

Is there not any option of setting useManualAudio = NO ? When I set it, I receive nothing on the web portal. So ideally, this is not an extension of GoogleWebRTC, It is a modified version of that with ONLY manual audio support. Am I right?

@akihikodaki
Copy link
Contributor

It wouldn't work if you set YES to useManualAudio and NO to isAudioEnabled in broadcast extension. It should work in a normal application.

@chaudharyvivek
Copy link
Author

I am not sure if I am able to explain my issue. Here is more explanation. I have two cases to achieve-
Case 1 - I need to pass my own audio buffers via webRTC. I have successfully achieved this via this extension.
Case 2 - I need to use it exactly same as GoogleWebRTC i.e. I don't want to pass audio buffers manually. I am unable to achieve this via this extension. Is this the limitation?

Thanks for your help.

@akihikodaki
Copy link
Contributor

Yes, that is the limitation of broadcast extension. useManualAudio and isAudioEnabled are exposed just to make it compatible with both of the extension and normal application.

@chaudharyvivek
Copy link
Author

I have a normal working application (iOS) where GoogleWebRTC is integrated and working fine. I just replaced GoogleWebRTC framework with the framework at this link - https://github.com/pixiv/webrtc/releases
My normal application stopped working. It only works if I provide sample buffer.
Will my normal application stop working with this framework?

@akihikodaki
Copy link
Contributor

No, it should work. I have no idea why your application stopped working.

@chaudharyvivek
Copy link
Author

Our project implementation is same as this - https://github.com/stasel/WebRTC-iOS
It works fine with GoogleWebRTC but not with this pixiv extension. Our project implementation works fine with the pixiv extension only if we pass buffer manually. Is there any additional setting or we need to set any additional property to make it work in automatic mode (without passing the manual CMSampleBuffer)?

@akihikodaki
Copy link
Contributor

No. You have to debug your application with pixiv extension to see what went wrong.

@chaudharyvivek
Copy link
Author

Can you please provide the steps to compile the ObjC framework from source?

@nmalevich
Copy link

Hi!
Any solution for this problem?
I have the same issue

How should I configure audioSession in common iOS app? I have implemented that on broadcast extension
Thanks for your answers

@shenfusheng
Copy link

shenfusheng commented Aug 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants