Related project

[aik099]

It appears that I need to have this protocol handler 2 months before you and created this project: https://github.com/aik099/PhpStormProtocol

It also has instructions on how to setup this in Linux & Windows.

At the end after PhpStorm 8 release both our repos wouldn't be useful due native url handler support by PhpStorm itself.

[aik099]

Also I've noticed that urlencoded file urls aren't supported, because they are not decoded before given to PhpStorm. But that doesn't matter now I guess.

[pinepain]

Great minders think alike. I saw your solution, nice catch!

I prefer to stick to KISS and keep the app ready for use immediately after downloading.

As of May 16 there are built-in idea:// and phpstorm:// protocols support in PhpStorm 8 EAP 138.190+ according to this comment from phpstorm team member.

As to urlencoding - who cares? I don't think that someone have files names with ampersands and equal sign to intersect with url schema.

Thanks for picking me up, I even forgot to track that bug on jetbrains site!

[aik099]

As to urlencoding - who cares? I don't think that someone have files names with ampersands and equal sign to intersect with url schema.

Ha, then you don't encode urls properly in your apps. Since in <a href="url_here">...</a> url is in HTML tag attribute, then it needs to be encoded using htmlspecialchars (PHP function) and not rawurlencode. Anyway I've seen frameworks, like Nette, that does encode it right and with them urls don't open in PhpStorm.

The solution via LinCastor (mentioned on my repo) deals with encoded urls just fine by the way.

[pinepain]

Can you post some meta-example to show the problem? I guess <a href="phpstorm://open?file=/some/file.txt&line=42"> will works fine.

[aik099]

Sure, it's bug report in my repo, that's why I know: aik099/PhpStormProtocol#6

[pinepain]

I don't see there any link example and in addition it seems to be that the problem is windows-specific there. Maybe it is not a right way to deal with such kind of potential issues, but (at least my app) works even without any url encoding/decoding.

[aik099]

Of course. The more users use the app, the more bug reports comes in. I also thought that I got all cases covered when released it 😄