Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail zip code population conditional when zip code is not found in the database #175

Open
jzonthemtn opened this issue Dec 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jzonthemtn
Copy link
Member

jzonthemtn commented Dec 13, 2024

If a zip code is not found in the local database, its population will be returned as -1.

Conditional checks involving zip code population should not consider -1 as a valid population. For instance, the zip code 12345 will return -1, and a condition that says "population < 500" will be evaluated as true. We can't be certain that is actually a true statement so the conditional should fail.

See #173 for a little more context.

@jzonthemtn jzonthemtn added the bug Something isn't working label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant