Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes to remove Redis name #164

Open
jzonthemtn opened this issue Nov 21, 2024 · 1 comment
Open

Update classes to remove Redis name #164

jzonthemtn opened this issue Nov 21, 2024 · 1 comment

Comments

@jzonthemtn
Copy link
Member

Phileas uses Redis for caching in various places - alerts, anonymization, span disambiguation, and policies.

While Phileas does not use Redis itself, these classes have names that include Redis, such as RedisAlertService, and its underlying AbstractRedisCacheService.

Phileas does have a dependency on the redisson client library which is available under the Apache license. Redisson also supports valkey, the Redis fork available under an open source license. AWS is offering valkey as a managed service.

The class naming with respect to Redis should be made generic to not imply that Redis is required for Phileas, when valkey is also an option.

@jzonthemtn
Copy link
Member Author

jzonthemtn commented Dec 13, 2024

The bigger idea here is that the cache should not have to be Redis (or Valkey). The abstract cache service should allow for a lot of implementations. Having the abstract class service named AbstractRedisCacheService is very restricting.

I don't like that the AbstractRedisCacheService strongly implies a dependency on Redis.

@jzonthemtn jzonthemtn changed the title Update classes to remove Redis name due to license changes Update classes to remove Redis name Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant