Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declutter IAddRemoveComponent to use explicit Link and Relate functions rather than Overloads #35

Open
thygrrr opened this issue Nov 6, 2024 · 0 comments
Labels
feature New Functionality and Changes
Milestone

Comments

@thygrrr
Copy link
Collaborator

thygrrr commented Nov 6, 2024

The overload space in Add and Remove is getting very cramped, obscuring a core feature of ECS by letting two more fringe features get in the way.

Disadvantages

  • hard to pick the right overload
  • picking the wrong overload can cause issues such as creating an Object Link when trying to create a normal component, etc.
  • code is difficult to read

Impact

Breaking Change, but [Obsolete] attributes will help migrating code.

Requires extensive Rework of Documentation and samples!

@thygrrr thygrrr converted this from a draft issue Nov 6, 2024
@thygrrr thygrrr added the feature New Functionality and Changes label Nov 6, 2024
@thygrrr thygrrr moved this to Ready in fennecs ⚡🦊 Nov 6, 2024
@thygrrr thygrrr added this to the 0.6.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Functionality and Changes
Projects
Status: Ready
Development

No branches or pull requests

1 participant