New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Hash Collision in Query Cache #30

Open

thygrrr opened this issue Nov 1, 2024 · 0 comments

Collaborator

thygrrr commented Nov 1, 2024 •

edited

Loading

Query Cache uses just a hash to determine mask equality.

This can lead to incorrect queries being returned by the cache.

It should be used like a proper dictionary, it will require a fast equality check for masks.

It's possible to keep a field in Mask to tag it retroactively as "resolved", but this adds some obtuse logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment