Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Links can be redirected by overwriting the Reference in a Runner or Ref #19

Open
thygrrr opened this issue Sep 13, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@thygrrr
Copy link
Collaborator

thygrrr commented Sep 13, 2024

What

The backing pointer for an ObjectLink can be made to deviate from the actual Object during later runtime; the Entity will then still be in the same archetype (which is either in one or two ways not what the user would expect).

How to Fix

Object Links need to be either Devoid (and have objects in a separate storage), or need to be treated per-archetype or cross-archetype in a 1-slot storage type.

The component type then needs to be migrated to reflect the new hash code.

Alternative: Disallow reseating Object refs in runners or otherwise. This can be done through postprocessing and raising an error most easily, but it would be preferable if the shared object wasn't provided as a ref in the first place. This, however, likely adds unnecessary complexity to the runner declarations.

@thygrrr thygrrr added the bug Something isn't working label Sep 13, 2024
@thygrrr thygrrr modified the milestones: 0.6.0, 0.6.0-beta Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant