Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what, if any, third party NPM modules should be installed by default #32

Open
lance opened this issue Aug 2, 2019 · 4 comments

Comments

@lance
Copy link
Member

lance commented Aug 2, 2019

The runtime image could install a curated set of NPM modules that are there by default. This would allow users to avoid having to specify these in a package.json file. In simple cases, this would mean that the user could avoid an npm install step altogether.

@lance lance transferred this issue from openshift-cloud-functions/faas-js-runtime-image Oct 17, 2019
@lance
Copy link
Member Author

lance commented Nov 15, 2019

Based on off-github conversations with @slinkydeveloper, we should at least consider bundling the top three or four test frameworks with the runtime image.

@lance
Copy link
Member Author

lance commented Nov 15, 2019

I am moving this issue to faas-js-runtime-image since whatever modules are installed will be installed globally on the image itself, and not as a part of this framework.

@lance lance transferred this issue from nodeshift/faas-js-runtime Nov 15, 2019
@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Nov 16, 2019

Sorry I badly explained myself. I mean that in kfn we should support them to install locally and let the generated package.json use them. But the runtime image itself don't need it at all imo

@lance
Copy link
Member Author

lance commented Nov 18, 2019

@slinkydeveloper I think having a handful of pre-installed modules on the image is potentially good for build time - less to install. Then, if kfn has a --test-framework=[jest|mocha|jasmine|tape], a package.json can be written with the appropriate test script, and there is nothing to install if we have all of those already in the global node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants