Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: XCALibre.jl: an XPU unstructured finite volume Computational Fluid Dynamics library #7408

Open
editorialbot opened this issue Oct 24, 2024 · 17 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 24, 2024

Submitting author: @mberto79 (Humberto Medina)
Repository: https://github.com/mberto79/XCALibre.jl
Branch with paper.md (empty if default branch): joss-submission
Version: v0.3.1
Editor: @AnjaliSandip
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d"><img src="https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d/status.svg)](https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d)

Author instructions

Thanks for submitting your paper to JOSS @mberto79. Currently, there isn't a JOSS editor assigned to your paper.

@mberto79 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 24, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.00602 is OK
- 10.5281/zenodo.7808904 is OK
- 10.1007/s12532-023-00239-3 is OK
- 10.21105/joss.02018 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.2514/3.10041 is OK
- 10.21105/joss.05187 is OK
- 10.1063/5.0166685 is OK
- 10.1016/j.ijheatmasstransfer.2024.126150 is OK
- 10.1175/1520-0493(1963)091<0099:GCEWTP>2.3.CO;2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Open Field Operation and Manipulation
- No DOI given, and none found for title: SU2
- No DOI given, and none found for title: CODE_SATURN
- No DOI given, and none found for title: Differentialequations.jl–a performant and feature-...
- No DOI given, and none found for title: Knet
- No DOI given, and none found for title: Instead of Rewriting Foreign Code for Machine Lear...
- No DOI given, and none found for title: WaterLily.jl: A differentiable and backend-agnosti...

❌ MISSING DOIs

- 10.1079/cabicompendium.102342 may be a valid DOI for title: Gerris

❌ INVALID DOIs

- https://doi.org/10.1016/j.ijheatfluidflow.2017.12.008 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.22 s (959.3 files/s, 132965.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          168           3602           3294          15344
CSV                              4              0              0           2508
Markdown                        22            759              0           2251
SVG                              4              0              0            525
TeX                              1             19              0            190
GLSL                             3             22             35            120
YAML                             3              3              5             86
TOML                             3              5              0             63
-------------------------------------------------------------------------------
SUM:                           208           4410           3334          21087
-------------------------------------------------------------------------------

Commit count by author:

   842	Humberto
   313	OscarOsborn
   246	TomMazin
   157	mberto79
   143	Humberto Medina
    53	Christopher D. Ellis
     4	Tim
     1	s-ambrose-9

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1555

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Mozilla Public License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

@editorialbot invite @AnjaliSandip as editor

Hi @AnjaliSandip, could you handle this submission?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SyntheticEddyMethod.jl: A Julia package for the creation of inlet flow conditions for LES
Submitting author: @carlodev
Handling editor: @philipcardiff (Active)
Reviewers: @atzberg, @akshaysridhar
Similarity score: 0.7575

GridapDistributed: a massively parallel finite element toolbox in Julia
Submitting author: @amartinhuertas
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown
Similarity score: 0.7516

Kinetic.jl: A portable finite volume toolbox for scientific and neural computing
Submitting author: @vavrines
Handling editor: @diehlpk (Active)
Reviewers: @rdeits, @jarvist
Similarity score: 0.7508

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia
Submitting author: @lluisjofre
Handling editor: @diehlpk (Active)
Reviewers: @ctdegroot, @thomasgillis
Similarity score: 0.7481

HallThruster.jl: a Julia package for 1D Hall thruster discharge simulation
Submitting author: @archermarx
Handling editor: @lucydot (Active)
Reviewers: @Rupali-Sahu, @TomGoffrey, @lucydot
Similarity score: 0.7475

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@AnjaliSandip
Copy link

@kyleniemeyer, I am happy to edit this submission.

@AnjaliSandip AnjaliSandip self-assigned this Oct 24, 2024
@kyleniemeyer
Copy link

@editorialbot assign @AnjaliSandip as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @AnjaliSandip is now the editor

@AnjaliSandip
Copy link

@mberto79, if you have any suggestions for potential reviewers, please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

@mberto79
Copy link

mberto79 commented Oct 29, 2024

Hi @AnjaliSandip,

Thank you for agreeing to act as the editor for our submission.

I looked at the list and I have a list of potential reviewers (with a short justification):

justinsgray - background in aerodynamics could be valuable to comment on application side.

Vincent Le Chenadec - background in numerical analysis, an in particular linear algebra, could be valuable to comment on approaches we used to solve the linear systems resulting from the VFM discretisation

mancellin - background in Finite Volume Method could be valuable since this is the underpinning method used in XCALibre.jl

simone-silvestri - background in CUDA could be valuable to comment on the approach used to write for multiple compute backends

Kind regards,
Humberto

@AnjaliSandip
Copy link

AnjaliSandip commented Oct 30, 2024

👋@JustinSGray, @mancellin, @vlc1 & @simone-silvestri, would you review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html.

@vlc1
Copy link

vlc1 commented Oct 30, 2024

Hi @AnjaliSandip sure thing!

@simone-silvestri
Copy link

Hi @AnjaliSandip sure, the project seems very interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants