Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: solids4foam-v2.1: A toolbox for performing solid mechanics and fluid-solid interaction simulations in OpenFOAM #7407

Open
editorialbot opened this issue Oct 24, 2024 · 8 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @philipcardiff (Philip Cardiff)
Repository: https://github.com/solids4foam/solids4foam
Branch with paper.md (empty if default branch): joss
Version: v2.1
Editor: @kyleniemeyer
Reviewers: @MakisH, @mohd-afeef-badri
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377"><img src="https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377/status.svg)](https://joss.theoj.org/papers/9df91b3fae09cdb1d85306a77f9b1377)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@MakisH & @mohd-afeef-badri, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@MakisH, please create your checklist typing: @editorialbot generate my checklist

@mohd-afeef-badri, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.71 s (1271.2 files/s, 310890.4 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                             364          25062          22528         103345
C/C++ Header                    348          15669          18459          23230
Markdown                         38           1816              0           4135
Bourne Again Shell              120            702            646           1931
m4                                7            136              0            772
Bourne Shell                     10            128            261            625
TeX                               1             15              0            177
YAML                              4             20              8            131
XML                               2             14              0            125
Fortran 77                        1              7              5             52
Dockerfile                        4             27             43             39
HLSL                              1              0              0              8
--------------------------------------------------------------------------------
SUM:                            900          43596          41950         134570
--------------------------------------------------------------------------------

Commit count by author:

   959	Philip Cardiff
    63	Danial Khazaei
    16	Iago Lessa de Oliveira
     6	philipcardiff
     3	Jeff Heylmun
     3	wyldckat
     2	Saber Mohammadi
     2	Zeljko Tukovic
     2	iagolessa
     2	scottlevie97
     1	Cyrille Bonamy
     1	Karen FitzGerald
     1	Philipp Milovic
     1	Sindeev Sergey
     1	emadtandis

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 668

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.48550/arXiv.1808.10736 is OK
- 10.1002/nag.2361 is OK
- 10.1016/j.jmbbm.2022.105498 is OK
- 10.1016/j.compbiomed.2023.107178 is OK
- 10.1016/j.apm.2021.09.009 is OK
- 10.1002/nme.7302 is OK
- 10.1016/j.commatsci.2012.03.011 is OK
- 10.1016/j.cma.2013.09.008 is OK
- 10.1016/j.compstruc.2016.07.004 is OK
- 10.1002/nme.5345 is OK
- 10.21278/TOF.42301 is OK
- 10.1007/978-3-319-60846-4_1 is OK
- 10.1016/j.compstruc.2008.11.013 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: OpenFOAM.com
- No DOI given, and none found for title: OpenFOAM.org
- No DOI given, and none found for title: foam-extend project

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@kyleniemeyer
Copy link

👋 @philipcardiff @MakisH @mohd-afeef-badri the actual review will take place in here.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@philipcardiff
Copy link

FYI @iBatistic @ztukovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants